linux-kernel - Re: [PATCH v2] pstore-ram: add Device Tree bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <564F6728.7050607@google.com>
Date:	Fri, 20 Nov 2015 10:32:08 -0800
From:	Greg Hackmann <ghackmann@...gle.com>
To:	Rob Herring <robh@...nel.org>
Cc:	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Jonathan Corbet <corbet@....net>,
	Anton Vorontsov <anton@...msg.org>,
	Colin Cross <ccross@...roid.com>,
	Kees Cook <keescook@...omium.org>,
	Tony Luck <tony.luck@...el.com>, linux-doc@...r.kernel.org
Subject: Re: [PATCH v2] pstore-ram: add Device Tree bindings

On 11/17/2015 01:17 PM, Rob Herring wrote:
>> +- record-size: maximum size in bytes of each dump done on oops/panic
>> +  (defaults to 0)
>
> Perhaps the default should be something useful.

It's kind of a weird default, but I don't have any ideas for a better one.

First, the size you want is really determined by the number of dumps you 
want to keep in your circular buffer. That's not something I want to 
guess at.

Second, at least IME, a lot of devices legitimately want this set to 0. 
They're pulling in ramoops for the persistent kernel and userspace logs.

>> +- unbuffered: if present, use uncached mappings to map the reserved region
>> +  (defaults to cached mappings)
>
> It defaults to write-combined or buffered which is not really cached.

Will fix.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/