| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <87vb8tyttv.fsf@rasmusvillemoes.dk> Date: Mon, 23 Nov 2015 09:59:40 +0100 From: Rasmus Villemoes <linux@...musvillemoes.dk> To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org Subject: Re: [PATCH v1 3/7] test_hexdump: go through all possible lengths of buffer On Fri, Nov 20 2015, Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote: > On Thu, 2015-11-19 at 11:07 +0100, Rasmus Villemoes wrote: >> >> >> Why keep the variable l when it is just a synonym for the new >> parameter buflen? It is quite confusing that you change some but not >> all occurrences of l to buflen. If you want to make the diff minimal >> but still have a descriptive parameter name, just keep the 'size_t l >> = >> buflen;' assignment and don't otherwise refer to buflen. But I think >> it's better to eliminate 'l' and just change everything to >> buflen. Don't mix the two approaches, though. > > Okay, I got it for the future, though the series is already in linux- > next, so do we really need to re-hack half of it because of that? Stuff in -next isn't set in stone. I'm pretty sure Andrew can replace one set of patches with another. Rasmus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists