linux-kernel - Re: [PATCH] mm: fix up sparse warning in gfpflags_allow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 23 Nov 2015 06:50:33 -0500
From:	Jeff Layton <jlayton@...chiereds.net>
To:	Michal Hocko <mhocko@...nel.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Mel Gorman <mgorman@...hsingularity.net>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: fix up sparse warning in gfpflags_allow_blocking

On Mon, 23 Nov 2015 10:50:49 +0100
Michal Hocko <mhocko@...nel.org> wrote:

> On Fri 20-11-15 09:40:59, Jeff Layton wrote:
> > sparse says:
> > 
> >     include/linux/gfp.h:274:26: warning: incorrect type in return expression (different base types)
> >     include/linux/gfp.h:274:26:    expected bool
> >     include/linux/gfp.h:274:26:    got restricted gfp_t
> > 
> > ...add a forced cast to silence the warning.
> > 
> > Cc: Mel Gorman <mgorman@...hsingularity.net>
> > Signed-off-by: Jeff Layton <jeff.layton@...marydata.com>
> > ---
> >  include/linux/gfp.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/include/linux/gfp.h b/include/linux/gfp.h
> > index 6523109e136d..8942af0813e3 100644
> > --- a/include/linux/gfp.h
> > +++ b/include/linux/gfp.h
> > @@ -271,7 +271,7 @@ static inline int gfpflags_to_migratetype(const gfp_t gfp_flags)
> >  
> >  static inline bool gfpflags_allow_blocking(const gfp_t gfp_flags)
> >  {
> > -	return gfp_flags & __GFP_DIRECT_RECLAIM;
> > +	return (bool __force)(gfp_flags & __GFP_DIRECT_RECLAIM);
> 
> Wouldn't (gfp_flags & __GFP_DIRECT_RECLAIM) != 0 be easier/better to read?
> 

Yeah, good point. Andrew, do you want me to respin that?

-- 
Jeff Layton <jlayton@...chiereds.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/