lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 23 Nov 2015 15:26:18 +0800 From: Chen-Yu Tsai <wens@...e.org> To: Julia Lawall <Julia.Lawall@...6.fr> Cc: David Woodhouse <dwmw2@...radead.org>, kernel-janitors@...r.kernel.org, Brian Norris <computersforpeace@...il.com>, Maxime Ripard <maxime.ripard@...e-electrons.com>, Chen-Yu Tsai <wens@...e.org>, linux-mtd@...ts.infradead.org, linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, linux-kernel <linux-kernel@...r.kernel.org>, Russell King - ARM Linux <linux@....linux.org.uk>, Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>, Andrew Lunn <andrew@...n.ch>, Bjorn Helgaas <bhelgaas@...gle.com>, Jason Cooper <jason@...edaemon.net> Subject: Re: [PATCH 2/4] mtd: nand: sunxi: add missing of_node_put On Thu, Nov 19, 2015 at 6:04 AM, Julia Lawall <Julia.Lawall@...6.fr> wrote: > for_each_child_of_node performs an of_node_get on each iteration, so > a break out of the loop requires an of_node_put. > > A simplified version of the semantic patch that fixes this problem is as > follows (http://coccinelle.lip6.fr): > > // <smpl> > @@ > expression root,e; > local idexpression child; > @@ > > for_each_child_of_node(root, child) { > ... when != of_node_put(child) > when != e = child > ( > return child; > | > + of_node_put(child); > ? return ...; > ) > ... > } > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr> Acked-by: Chen-Yu Tsai <wens@...e.org> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists