lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 23 Nov 2015 07:29:43 +0000 (GMT) From: MyungJoo Ham <myungjoo.ham@...sung.com> To: 최찬우 <cw00.choi@...sung.com>, 박경민 <kyungmin.park@...sung.com> Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org> Subject: Re: [PATCH 4/6] PM / devfreq: Set the freq_table of devfreq device > > This patch initialize the freq_table array of each devfreq device by using > the devfreq_set_freq_table(). If freq_table is NULL, the devfreq framework > is not able to support the frequency transtion information through sysfs. > > The OPP core uses the integer type for the number of opps in the opp list > and uses the 'unsigned long' type for each frequency. So, this patch modifies > the type of some variable as following: > - the type of freq_table : unsigned int -> unsigned long > - the type of max_state : unsigned int -> int > > Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com> [] > +/** > * devfreq_update_status() - Update statistics of devfreq behavior > * @devfreq: the devfreq instance > * @freq: the update target frequency > @@ -477,7 +516,12 @@ struct devfreq *devfreq_add_device(struct device *dev, > devfreq->previous_freq = profile->initial_freq; > devfreq->data = data; > devfreq->nb.notifier_call = devfreq_notifier_call; > + mutex_unlock(&devfreq->lock); > > + if (devfreq->profile->max_state <= 0 && !devfreq->profile->freq_table) > + devfreq_set_freq_table(devfreq); > + > + mutex_lock(&devfreq->lock); Anyway, what about modifying the block above as: + if (!devfreq->profile->max_state && !devfreq->profile->freq_table) { + mutex_unlock(&devfreq->lock); devfreq_set_freq_table(devfreq); + mutex_lock(&devfreq->lock); + } > devfreq->trans_table = devm_kzalloc(dev, sizeof(unsigned int) * > devfreq->profile->max_state * > devfreq->profile->max_state, [] If that's not a problem, I'll squash https://git.kernel.org/cgit/linux/kernel/git/mzx/devfreq.git/commit/?h=for-rafael&id=55df2b43cdb5ac82d26b64d739f3d758c9b7486c with the given patch.
Powered by blists - more mailing lists