linux-kernel - Re: [PATCH] thermal: exynos: use of_property_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Nov 2015 15:29:38 -0800
From:	Eduardo Valentin <edubezval@...il.com>
To:	Saurabh Sengar <saurabh.truth@...il.com>
Cc:	l.majewski@...sung.com, rui.zhang@...el.com, kgene@...nel.org,
	k.kozlowski@...sung.com, linux-samsung-soc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thermal: exynos: use of_property_read_u8()

On Mon, Nov 23, 2015 at 07:40:41PM +0530, Saurabh Sengar wrote:
> use of_property_read_u8() for u8 variables,
> also changed the return type to void as this function return type
> is nowhere used.
> 

I would be good if you could split both changes into two patches.

Also, I still do not understand properly the proposal to use u8.

Why are they u8?

If they are so, please document them in their DT bindings. Today, the
bindings tell us they are s32 (as there is nothing really specifying the
type).


BR


> Signed-off-by: Saurabh Sengar <saurabh.truth@...il.com>
> ---
>  drivers/thermal/samsung/exynos_tmu.c | 30 +++++++++++++-----------------
>  1 file changed, 13 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
> index fa61eff..b692c95 100644
> --- a/drivers/thermal/samsung/exynos_tmu.c
> +++ b/drivers/thermal/samsung/exynos_tmu.c
> @@ -1128,20 +1128,16 @@ static int exynos_of_get_soc_type(struct device_node *np)
>  	return -EINVAL;
>  }
>  
> -static int exynos_of_sensor_conf(struct device_node *np,
> +static void exynos_of_sensor_conf(struct device_node *np,
>  				 struct exynos_tmu_platform_data *pdata)
>  {
> -	u32 value;
> -	int ret;
> -
>  	of_node_get(np);
>  
> -	ret = of_property_read_u32(np, "samsung,tmu_gain", &value);
> -	pdata->gain = (u8)value;
> -	of_property_read_u32(np, "samsung,tmu_reference_voltage", &value);
> -	pdata->reference_voltage = (u8)value;
> -	of_property_read_u32(np, "samsung,tmu_noise_cancel_mode", &value);
> -	pdata->noise_cancel_mode = (u8)value;
> +	of_property_read_u8(np, "samsung,tmu_gain", &pdata->gain);
> +	of_property_read_u8(np, "samsung,tmu_reference_voltage",
> +				&pdata->reference_voltage);
> +	of_property_read_u8(np, "samsung,tmu_noise_cancel_mode",
> +				&pdata->noise_cancel_mode);
>  
>  	of_property_read_u32(np, "samsung,tmu_efuse_value",
>  			     &pdata->efuse_value);
> @@ -1150,18 +1146,18 @@ static int exynos_of_sensor_conf(struct device_node *np,
>  	of_property_read_u32(np, "samsung,tmu_max_efuse_value",
>  			     &pdata->max_efuse_value);
>  
> -	of_property_read_u32(np, "samsung,tmu_first_point_trim", &value);
> -	pdata->first_point_trim = (u8)value;
> -	of_property_read_u32(np, "samsung,tmu_second_point_trim", &value);
> -	pdata->second_point_trim = (u8)value;
> -	of_property_read_u32(np, "samsung,tmu_default_temp_offset", &value);
> -	pdata->default_temp_offset = (u8)value;
> +	of_property_read_u8(np, "samsung,tmu_first_point_trim",
> +				&pdata->first_point_trim);
> +	of_property_read_u8(np, "samsung,tmu_second_point_trim",
> +				&pdata->second_point_trim);
> +	of_property_read_u8(np, "samsung,tmu_default_temp_offset",
> +				&pdata->default_temp_offset);
>  
>  	of_property_read_u32(np, "samsung,tmu_cal_type", &pdata->cal_type);
>  	of_property_read_u32(np, "samsung,tmu_cal_mode", &pdata->cal_mode);
>  
>  	of_node_put(np);
> -	return 0;
> +	return;

The landing return; is not needed.

>  }
>  
>  static int exynos_map_dt_data(struct platform_device *pdev)
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/