lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 24 Nov 2015 10:28:25 +0900 From: Krzysztof Kozlowski <k.kozlowski@...sung.com> To: Eduardo Valentin <edubezval@...il.com>, Saurabh Sengar <saurabh.truth@...il.com> Cc: l.majewski@...sung.com, rui.zhang@...el.com, kgene@...nel.org, linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] thermal: exynos: use of_property_read_u8() On 24.11.2015 08:29, Eduardo Valentin wrote: > On Mon, Nov 23, 2015 at 07:40:41PM +0530, Saurabh Sengar wrote: >> use of_property_read_u8() for u8 variables, >> also changed the return type to void as this function return type >> is nowhere used. >> > > I would be good if you could split both changes into two patches. > > Also, I still do not understand properly the proposal to use u8. > > Why are they u8? > > If they are so, please document them in their DT bindings. Today, the > bindings tell us they are s32 (as there is nothing really specifying the > type). It looks like u8 came from platform data from old times when the driver did not support DT. All of our Exynos mainline boards are converted to DT, so I think legacy platform data can be also changed to match DT. Which means changing from u8 to u32. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists