linux-kernel - Re: [PATCH v2 3/5] lightnvm: create dma pool first

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56544376.1050801@lightnvm.io>
Date:	Tue, 24 Nov 2015 12:01:10 +0100
From:	Matias Bjørling <mb@...htnvm.io>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/5] lightnvm: create dma pool first

On 11/24/2015 11:34 AM, Sudip Mukherjee wrote:
> If create_dma_pool() fails then we are returning the error code but we
> have already added the device to the list. Lets add the device to the
> list only if everything is successfully initialized.
>
> Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> ---
>   drivers/lightnvm/core.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c
> index 2ab561f..d288996 100644
> --- a/drivers/lightnvm/core.c
> +++ b/drivers/lightnvm/core.c
> @@ -313,10 +313,6 @@ int nvm_register(struct request_queue *q, char *disk_name,
>   	if (ret)
>   		goto err_init;
>
> -	down_write(&nvm_lock);
> -	list_add(&dev->devices, &nvm_devices);
> -	up_write(&nvm_lock);
> -
>   	if (dev->ops->max_phys_sect > 1) {
>   		dev->ppalist_pool = dev->ops->create_dma_pool(dev->q,
>   								"ppalist");
> @@ -326,6 +322,10 @@ int nvm_register(struct request_queue *q, char *disk_name,
>   		}
>   	}
>
> +	down_write(&nvm_lock);
> +	list_add(&dev->devices, &nvm_devices);
> +	up_write(&nvm_lock);
> +
>   	return 0;
>   err_init:
>   	kfree(dev);
>

Thanks. This have already been fixed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/