linux-kernel - Re: [PATCH] mfd: qcom_rpm: fix a possible NULL dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151124164642.GD12874@x1>
Date:	Tue, 24 Nov 2015 16:46:42 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	LABBE Corentin <clabbe.montjoie@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: qcom_rpm: fix a possible NULL dereference

On Thu, 12 Nov 2015, LABBE Corentin wrote:

> of_match_device could return NULL, and so cause a NULL pointer
> dereference later.
> 
> Signed-off-by: LABBE Corentin <clabbe.montjoie@...il.com>
> ---
>  drivers/mfd/qcom_rpm.c | 2 ++
>  1 file changed, 2 insertions(+)

Applied, thanks.

> diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c
> index 207a3bd..1be47ad 100644
> --- a/drivers/mfd/qcom_rpm.c
> +++ b/drivers/mfd/qcom_rpm.c
> @@ -495,6 +495,8 @@ static int qcom_rpm_probe(struct platform_device *pdev)
>  	}
>  
>  	match = of_match_device(qcom_rpm_of_match, &pdev->dev);
> +	if (!match)
> +		return -ENODEV;
>  	rpm->data = match->data;
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/