linux-kernel - Re: [PATCH 03/14] DEVICETREE: Add PIC32 clock binding documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56568519.3060308@microchip.com>
Date:	Wed, 25 Nov 2015 21:05:45 -0700
From:	Joshua Henderson <joshua.henderson@...rochip.com>
To:	Arnd Bergmann <arnd@...db.de>
CC:	<linux-kernel@...r.kernel.org>, <linux-mips@...ux-mips.org>,
	Purna Chandra Mandal <purna.mandal@...rochip.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>, <devicetree@...r.kernel.org>
Subject: Re: [PATCH 03/14] DEVICETREE: Add PIC32 clock binding documentation

Hi Arnd,

On 11/21/2015 1:49 PM, Arnd Bergmann wrote:
> On Friday 20 November 2015 17:17:15 Joshua Henderson wrote:
>> +/* PIC32 specific clks */
>> +pic32_clktree {
>> +       #address-cells = <1>;
>> +       #size-cells = <1>;
>> +       reg = <0x1f801200 0x200>;
>> +       compatible = "microchip,pic32-clk";
>> +       interrupts = <12>;
>> +       ranges;
>> +
>> +       /* secondary oscillator; external input on SOSCI pin */
>> +       SOSC:sosc_clk {
>> +               #clock-cells = <0>;
>> +               compatible = "microchip,pic32-sosc";
>> +               clock-frequency = <32768>;
>> +               reg = <0x1f801200 0x10   /* enable reg */
>> +                       0x1f801390 0x10>; /* status reg */
>> +               microchip,bit-mask = <0x02>; /* enable mask */
>> +               microchip,status-bit-mask = <0x10>; /* status-mask*/
>> +       };
>>
> 
> If you want to use the reg property in this way for each cell,
> at least use a 'ranges' that only translates the actual registers
> like this
> 
> 	ranges = <0 0x1f801200 0x200>
> 
> 	sosc_clk {
> 		...
> 		reg = <0x000 0x10>, <0x190 0x10>;
> 		...
> 	};
> 
> 	Arnd
> 

This does indeed seem to be the correct way to use ranges in this case.  Consider it done.

Thanks for the feedback,
Josh


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/