lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 25 Nov 2015 21:40:23 -0700 From: Joshua Henderson <joshua.henderson@...rochip.com> To: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>, <linux-kernel@...r.kernel.org> CC: <linux-mips@...ux-mips.org>, Andrei Pistirica <andrei.pistirica@...rochip.com>, Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>, Mark Rutland <mark.rutland@....com>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Kumar Gala <galak@...eaurora.org>, <devicetree@...r.kernel.org> Subject: Re: [PATCH 12/14] DEVICETREE: Add bindings for PIC32 SDHC host controller Hi Sergei, On 11/21/2015 8:19 AM, Sergei Shtylyov wrote: > Hello. > > On 11/21/2015 3:17 AM, Joshua Henderson wrote: > >> From: Andrei Pistirica <andrei.pistirica@...rochip.com> >> >> Document the devicetree bindings for the SDHC peripheral found on >> Microchip PIC32 class devices. >> >> Signed-off-by: Andrei Pistirica <andrei.pistirica@...rochip.com> >> Signed-off-by: Joshua Henderson <joshua.henderson@...rochip.com> >> --- >> .../devicetree/bindings/mmc/sdhci-pic32.txt | 24 ++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-pic32.txt >> >> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-pic32.txt b/Documentation/devicetree/bindings/mmc/sdhci-pic32.txt >> new file mode 100644 >> index 0000000..f16388c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mmc/sdhci-pic32.txt >> @@ -0,0 +1,24 @@ >> +* Microchip PIC32 SDHCI Controller >> + >> +This file documents differences between the core properties in mmc.txt >> +and the properties used by the sdhci-pic32 driver. >> + >> +Required properties: >> +- compatible: Should be "microchip,pic32-sdhci" >> +- reg: Should contain registers location and length >> +- interrupts: Should contain interrupt >> +- pinctrl: Should contain pinctrl for data and command lines > > This is a required prop, yet the example doesn't contain it? > Ack. Both the required properties and example need to contain pinctrl-names and pinctrl-0, not pinctrl. >> + >> +Optional properties: >> +- no-1-8-v: 1.8V voltage selection not supported >> +- piomode: disable DMA support >> + >> +Example: >> + >> + sdhci@...ec000 { >> + compatible = "microchip,pic32-sdhci"; >> + reg = <0x1f8ec000 0x100>; >> + interrupts = <SDHC_EVENT DEFAULT_INT_PRI IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&REFCLKO4>, <&PBCLK5>; >> + clock-names = "base_clk", "sys_clk"; > > The "clocks" and "clock-names" props are not documented. > > [...] > > MBR, Sergei > Ack. Thanks for the feedback, Josh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists