linux-kernel - Re: [PATCH v4 2/5] PCI: iproc: Add PAXC interface support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 Nov 2015 21:22:21 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Ray Jui <rjui@...adcom.com>
Cc:	Bjorn Helgaas <bhelgaas@...gle.com>,
	Marc Zyngier <marc.zyngier@....com>,
	Hauke Mehrtens <hauke@...ke-m.de>,
	linux-kernel@...r.kernel.org,
	bcm-kernel-feedback-list@...adcom.com, linux-pci@...r.kernel.org
Subject: Re: [PATCH v4 2/5] PCI: iproc: Add PAXC interface support

On Friday 27 November 2015 09:37:45 Ray Jui wrote:
> 
> +static const struct of_device_id iproc_pcie_of_match_table[] = {
> +       {
> +               .compatible = "brcm,iproc-pcie",
> +               .data = (int *)IPROC_PCIE_PAXB,
> +       }, {
> +               .compatible = "brcm,iproc-pcie-paxc",
> +               .data = (int *)IPROC_PCIE_PAXC,
> +       },
> +       { /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(of, iproc_pcie_of_match_table);

You seem to only need the identifiers in order to set a single
pointer, so just point to that array directly. Alternatively,
do the more common thing and point to a structure of function
pointers and have different implementations of the low-level
access functions there.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/