linux-kernel - Re: [RESEND] scsi: mvsas: fix misleading indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1oaebdj9s.fsf@sermon.lab.mkp.net>
Date:	Mon, 30 Nov 2015 20:55:59 -0500
From:	"Martin K. Petersen" <martin.petersen@...cle.com>
To:	Luis de Bethencourt <luisbg@....samsung.com>
Cc:	linux-kernel@...r.kernel.org, vinholikatti@...il.com,
	JBottomley@...n.com, jthumshirn@...e.de,
	linux-scsi@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [RESEND] scsi: mvsas: fix misleading indentation

>>>>> "Luis" == Luis de Bethencourt <luisbg@....samsung.com> writes:

Luis> Fix a smatch warning: drivers/scsi/mvsas/mv_sas.c:740
Luis> mvs_task_prep() warn: curly braces intended?

Luis> The code is correct, the indention is misleading. When the device
Luis> is not ready we want to return SAS_PHY_DOWN. But current
Luis> indentation makes it look like we only do so in the else branch of
Luis> if (mvi_dev).

Applied to 4.5/scsi-queue.

Thank you!

-- 
Martin K. Petersen	Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/