linux-kernel - Re: [PATCH 2/2] usb: pci-quirks: register USB mux found on Cherrytrail SOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151202091514.GB7587@kuha.fi.intel.com>
Date:	Wed, 2 Dec 2015 11:15:14 +0200
From:	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:	Lu Baolu <baolu.lu@...ux.intel.com>
Cc:	Chanwoo Choi <cw00.choi@...sung.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	MyungJoo Ham <myungjoo.ham@...sung.com>,
	David Cohen <david.a.cohen@...ux.intel.com>,
	Mathias Nyman <mathias.nyman@...ux.intel.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] usb: pci-quirks: register USB mux found on
 Cherrytrail SOC

Hi,

> > @@ -1029,9 +1030,36 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev)
> >  	writel(val, base + ext_cap_offset + XHCI_LEGACY_CONTROL_OFFSET);
> >  
> >  hc_init:
> > -	if (pdev->vendor == PCI_VENDOR_ID_INTEL)
> > +	if (pdev->vendor == PCI_VENDOR_ID_INTEL) {
> >  		usb_enable_intel_xhci_ports(pdev);
> >  
> > +		/*
> > +		 * Initialize the internal mux that shares a port between USB
> > +		 * Device Controller and xHCI on platforms that have it.
> > +		 */
> > +#define XHCI_INTEL_VENDOR_CAPS 192
> > +#define XHCI_INTEL_USB_MUX_OFFSET 0x80d8
> > +		ext_cap_offset = xhci_find_next_cap_offset(base,
> > +							XHCI_HCC_PARAMS_OFFSET);
> > +		ext_cap_offset = xhci_find_ext_cap_by_id(base, ext_cap_offset,
> > +							XHCI_INTEL_VENDOR_CAPS);
> 
> Hi Heikki,
> 
> This helper has been replaced with xhci_find_next_ext_cap() in
> commit d5ddcdf(xhci: rework xhci extended capability list parsing functions).
> 
> Need to fix this, otherwise it will not pass compile on top of usb-next.

Thanks Baolu. I'll fix it.


Cheers,

-- 
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/