lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 2 Dec 2015 12:27:10 +0200 From: Heikki Krogerus <heikki.krogerus@...ux.intel.com> To: David Cohen <david.a.cohen@...ux.intel.com> Cc: Chanwoo Choi <cw00.choi@...sung.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, MyungJoo Ham <myungjoo.ham@...sung.com>, Lu Baolu <baolu.lu@...ux.intel.com>, Mathias Nyman <mathias.nyman@...ux.intel.com>, linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/2] extcon: add driver for Intel USB mux Hi David, <snip> > > +void intel_usb_mux_unregister(struct intel_usb_mux *mux) > > +{ > > There are still 2 pending comments for this unregister function: > > 1) How about a protection against unbalanced unregistering? In case an > user mistakenly unregisters twice or unregisters without a previous > registering. True. You already pointed that out in our off-list thread, but I forgot. Sorry about that. > 2) When unregistering, you need to clear the bit CFG0_SW_IDPIN_EN to > set mux to automatic mode again. Or maybe you could save CFG0's initial > value and set it again here. Anyway, when unregistering the mux driver > you need to make sure the mux goes back to its original configuration. This one is already been taken care of.. > > + extcon_unregister_notifier(&mux->edev, EXTCON_USB_HOST, &mux->nb); > > + extcon_dev_unregister(&mux->edev); > > + writel(mux->cfg0_ctx, mux->regs + INTEL_MUX_CFG0); ^^^^^^^^^^^^^^^^^^^^ Thanks, -- heikki -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists