linux-kernel - Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3047121.2z9SCS5Au2@wuerfel>
Date:	Fri, 04 Dec 2015 11:49:44 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	xuejiancheng <xuejiancheng@...wei.com>
Cc:	linux-arm-kernel@...ts.infradead.org, robh+dt@...nel.org,
	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	linux@....linux.org.uk, khilman@...aro.org, olof@...om.net,
	xuwei5@...ilicon.com, haojian.zhuang@...aro.org,
	zhangfei.gao@...aro.org, bintian.wang@...wei.com,
	suwenping@...ilicon.com, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, yanhaifeng@...ilicon.com,
	gaofei@...ilicon.com, ml.yang@...ilicon.com,
	yanghongwei@...ilicon.com
Subject: Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

On Friday 04 December 2015 10:27:58 xuejiancheng wrote:
> > 
> >> +            sysctrl: system-controller@...20000 {
> >> +                    compatible = "hisilicon,sysctrl";
> >> +                    reg = <0x12020000 0x1000>;
> >> +                    reboot-offset = <0x4>;
> >> +            };
> > 
> > Is this one identical to the one in hip04?
> > 
> > If not, pick a new unique compatible string
> 
> Yes. It's compatible with the one in hip04.

Ok, we should add a compatible string for that then, as the hip04 apparently
has a slightly different layout from hip01.

Can you add a separate patch to clarify the existing hisilicon,sysctrl nodes?

It look like hi3620 accidentally uses the same string as hip04 already
but is actually a bit different.

Maybe split out the sysctrl binding from
Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt, as it has
you already have a couple of those, and it's not clear how they relate
to one another.

If we introduce a string for all hip04 compatible sysctrl devices, we should
document that and use it consistently, so hi3519 becomes

	compatible = "hisilicon,hi3519-sysctrl", "hisilicon,hip04-sysctrl", "hisilicon,sysctrl";

but I'd clarify in the binding documentation that "hisilicon,sysctrl" should
only be used for hip04 and hi3519 but not the others.

As this seems to be a standard part, we can also think about making a
high-level driver for in in drivers/soc rather than relying on the syscon
driver which we tend to use more for one-off devices with random register
layouts.

> >> +
> >> +            crg: crg@...10000 {
> >> +                    compatible = "hisilicon,hi3519-crg";
> > 
> > 
> > what is a "crg"? Is there a standard name for these?
> 
> The "crg" means Clock and Reset Generator. It's a block which supplies clock
> and reset signals for other modules in the chip. I used "hi3519-clock"
> in last version patch. Rob Herring suggested that it's better to use "hi3519-crg"
> as the compatible string if it's a whole block.
> 
> what about writing like this？
> 
> crg: clock-reset-controller@...10000 {
>         compatible = "hisilicon,hi3519-crg";
>         }
> 

Ok, that's better.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/