lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 07 Dec 2015 10:33:43 +0200 From: Jani Nikula <jani.nikula@...ux.intel.com> To: Zhaoxiu Zeng <zhaoxiu.zeng@...il.com>, daniel.vetter@...el.com, airlied@...ux.ie, intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org Cc: linux-kernel@...r.kernel.org, Zeng Zhaoxiu <zhaoxiu.zeng@...il.com> Subject: Re: [PATCH 03/10] i915: Replace "hweight8(dev_priv->info.subslice_7eu[i]) != 1" with "!is_power_of_2(dev_priv->info.subslice_7eu[i])" On Sun, 06 Dec 2015, Zhaoxiu Zeng <zhaoxiu.zeng@...il.com> wrote: > From: Zeng Zhaoxiu <zhaoxiu.zeng@...il.com> > > Signed-off-by: Zeng Zhaoxiu <zhaoxiu.zeng@...il.com> I'd like to see a commit message describing what is done and why, even for trivial changes. Now the subject line is essentially the diff in plain English, which adds no information to the patch itself. It doesn't even say that this should be a non-functional change. BR, Jani. > --- > drivers/gpu/drm/i915/intel_ringbuffer.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c > index 9461a23..16c8cf1 100644 > --- a/drivers/gpu/drm/i915/intel_ringbuffer.c > +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c > @@ -27,6 +27,7 @@ > * > */ > > +#include <linux/log2.h> > #include <drm/drmP.h> > #include "i915_drv.h" > #include <drm/i915_drm.h> > @@ -1000,7 +1001,7 @@ static int skl_tune_iz_hashing(struct intel_engine_cs *ring) > * Only consider slices where one, and only one, subslice has 7 > * EUs > */ > - if (hweight8(dev_priv->info.subslice_7eu[i]) != 1) > + if (!is_power_of_2(dev_priv->info.subslice_7eu[i])) > continue; > > /* -- Jani Nikula, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists