linux-kernel - Re: [PATCH] usb: whci: fhci: remove comparison to bool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 7 Dec 2015 11:09:33 +0100
From:	Peter Senna Tschudin <peter.senna@...il.com>
To:	"Geyslan G. Bem" <geyslan@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: whci: fhci: remove comparison to bool

On Wed, Dec 2, 2015 at 10:45 PM, Geyslan G. Bem <geyslan@...il.com> wrote:
> Get rid of bool explicit comparisons.
>
> Caught by Coccinelle.
I would mention the path to the .cocci script, but other than that:
Acked-by: Peter Senna Tschudin <peter.senna@...il.com>

>
> Signed-off-by: Geyslan G. Bem <geyslan@...il.com>
> ---
>  drivers/usb/host/fhci-tds.c  | 2 +-
>  drivers/usb/host/whci/qset.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/fhci-tds.c b/drivers/usb/host/fhci-tds.c
> index 1498061..f82ad5d 100644
> --- a/drivers/usb/host/fhci-tds.c
> +++ b/drivers/usb/host/fhci-tds.c
> @@ -85,7 +85,7 @@ static struct usb_td __iomem *next_bd(struct usb_td __iomem *base,
>
>  void fhci_push_dummy_bd(struct endpoint *ep)
>  {
> -       if (ep->already_pushed_dummy_bd == false) {
> +       if (!ep->already_pushed_dummy_bd) {
>                 u16 td_status = in_be16(&ep->empty_td->status);
>
>                 out_be32(&ep->empty_td->buf_ptr, DUMMY_BD_BUFFER);
> diff --git a/drivers/usb/host/whci/qset.c b/drivers/usb/host/whci/qset.c
> index 3297473..5e48a60 100644
> --- a/drivers/usb/host/whci/qset.c
> +++ b/drivers/usb/host/whci/qset.c
> @@ -395,7 +395,7 @@ static void urb_dequeue_work(struct work_struct *work)
>         struct whc *whc = qset->whc;
>         unsigned long flags;
>
> -       if (wurb->is_async == true)
> +       if (wurb->is_async)
>                 asl_update(whc, WUSBCMD_ASYNC_UPDATED
>                            | WUSBCMD_ASYNC_SYNCED_DB
>                            | WUSBCMD_ASYNC_QSET_RM);
> --
> 2.6.3
>



-- 
Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/