linux-kernel - Re: [PATCH] usb: use BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+MoWDrdw_5ijw_koecXU2y=QZ2GBHfDAoVYawefLRx3rd3NaQ@mail.gmail.com>
Date:	Mon, 7 Dec 2015 11:10:47 +0100
From:	Peter Senna Tschudin <peter.senna@...il.com>
To:	"Geyslan G. Bem" <geyslan@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	Julia Lawall <Julia.Lawall@...6.fr>,
	Saurabh Karajgaonkar <skarajga@...teon.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Felipe Balbi <balbi@...com>, linux-usb@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: use BUG_ON() instead of BUG()

On Wed, Dec 2, 2015 at 11:18 PM, Geyslan G. Bem <geyslan@...il.com> wrote:
> Replace BUG() with BUG_ON().
>
> Caught by coccinelle.
I would mention the path to the .cocci script, but other than that:
Acked-by: Peter Senna Tschudin <peter.senna@...il.com>

>
> Signed-off-by: Geyslan G. Bem <geyslan@...il.com>
> ---
>  drivers/usb/host/oxu210hp-hcd.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/usb/host/oxu210hp-hcd.c b/drivers/usb/host/oxu210hp-hcd.c
> index 1f139d8..bc74aca 100644
> --- a/drivers/usb/host/oxu210hp-hcd.c
> +++ b/drivers/usb/host/oxu210hp-hcd.c
> @@ -394,8 +394,7 @@ static void ehci_quiesce(struct oxu_hcd *oxu)
>         u32     temp;
>
>  #ifdef DEBUG
> -       if (!HC_IS_RUNNING(oxu_to_hcd(oxu)->state))
> -               BUG();
> +       BUG_ON(!HC_IS_RUNNING(oxu_to_hcd(oxu)->state));
>  #endif
>
>         /* wait for any schedule enables/disables to take effect */
> @@ -1709,9 +1708,8 @@ static void start_unlink_async(struct oxu_hcd *oxu, struct ehci_qh *qh)
>
>  #ifdef DEBUG
>         assert_spin_locked(&oxu->lock);
> -       if (oxu->reclaim || (qh->qh_state != QH_STATE_LINKED
> -                               && qh->qh_state != QH_STATE_UNLINK_WAIT))
> -               BUG();
> +       BUG_ON(oxu->reclaim || (qh->qh_state != QH_STATE_LINKED
> +                               && qh->qh_state != QH_STATE_UNLINK_WAIT));
>  #endif
>
>         /* stop async schedule right now? */
> --
> 2.6.3
>



-- 
Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/