linux-kernel - Re: [PATCH v5 2/2] video: fbdev: pxafb: initial devicetree conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5665B3C1.1080005@ti.com>
Date:	Mon, 7 Dec 2015 18:28:49 +0200
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Robert Jarzmik <robert.jarzmik@...e.fr>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>
CC:	<linux-fbdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 2/2] video: fbdev: pxafb: initial devicetree conversion


On 17/11/15 22:32, Robert Jarzmik wrote:
> This patch brings a first support of pxa framebuffer devices to a
> devicetree pxa platform, as was before platform data.
> 
> There are restrictions with this port, the biggest one being the lack of
> support of smart panels. Moreover the conversion doesn't provide a way
> to declare multiple framebuffer configurations with different bits per
> pixel, only the LCD hardware bus width is used.
> 
> The patch was tested on both pxa25x, pxa27x and pxa3xx platform (namely
> lubbock, mainstone and zylonite).
> 
> Signed-off-by: Robert Jarzmik <robert.jarzmik@...e.fr>
> ---
> Since v1: Philipp's review: of_graph usage
> Since v3: of_device_id sentinel, and all compatible ids added
> Since v4: fixed of_device_id table : rebase error on my side, with
>           braces which were incorrectly added
> ---
>  drivers/video/fbdev/Kconfig |   2 +
>  drivers/video/fbdev/pxafb.c | 163 +++++++++++++++++++++++++++++++++++++++++++-
>  2 files changed, 162 insertions(+), 3 deletions(-)

I see we already have
Documentation/devicetree/bindings/display/marvell,pxa2xx-lcdc.txt in the
mainline. I think the patch adding the binding doc should have been kept
in this series.

It seems that at least "depth" is missing from the binding document.

 Tomi


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)