linux-kernel - Re: [PATCH v3] of: fix build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151207163006.GA3819@sudip-laptop>
Date:	Mon, 7 Dec 2015 22:00:06 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Rob Herring <robh+dt@...nel.org>,
	Frank Rowand <frowand.list@...il.com>,
	Grant Likely <grant.likely@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v3] of: fix build failure

On Mon, Dec 07, 2015 at 01:32:30PM +0100, Geert Uytterhoeven wrote:
> Hi Sudip,
> 
> On Mon, Dec 7, 2015 at 1:20 PM, Sudip Mukherjee
> <sudipm.mukherjee@...il.com> wrote:
> > We are having build failure with linux-next for sparc allmodconfig with
> > the error messages:
> >
> > undefined reference to 'of_io_request_and_map'
> >
> > CONFIG_OF is defined for sparc so it is expected that we have a
> > definition of of_io_request_and_map() but of/address.c is only compiled
> > if it is !SPARC. In other words, CONFIG_OF_ADDRESS is not defined for
> > sparc so we get the build failure.
> >
> > Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> > ---
> >
<snip>
> > diff --git a/include/linux/of_address.h b/include/linux/of_address.h
> > index 507daad..02b1265 100644
> > --- a/include/linux/of_address.h
> > +++ b/include/linux/of_address.h
> > @@ -112,8 +112,6 @@ static inline bool of_dma_is_coherent(struct device_node *np)
> >  extern int of_address_to_resource(struct device_node *dev, int index,
> >                                   struct resource *r);
> >  void __iomem *of_iomap(struct device_node *node, int index);
> > -void __iomem *of_io_request_and_map(struct device_node *device,
> > -                                       int index, const char *name);
> 
> Upon closer look, both of_address_to_resource() and of_iomap() are
> provided by drivers/of/address.c, so they should also be protected by
> #ifdef CONFIG_OF_ADDRESS instead of CONFIG_OF.
> Then the whole #ifdef CONFIG_OF section becomes empty.
> 
> >  #else
<snip>
> >
> >  #if defined(CONFIG_OF_ADDRESS) && defined(CONFIG_PCI)
> >  extern const __be32 *of_get_pci_address(struct device_node *dev, int bar_no,
> 
> Hence can you please move all of them to the existing
> #ifdef CONFIG_OF_ADDRESS section, and move the #include <linux/io.h>
> to the top?

oops, no. I think you have missed seeing few more places.
of_address_to_resource() of_iomap() are both defined in
arch/sparc/kernel/of_device_common.c
So if it is moved under #ifdef CONFIG_OF_ADDRESS then we again
get a build failure for duplicate definition of them.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/