linux-kernel - Re: [PATCH] drm: msm: dsi: Added missing mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 7 Dec 2015 11:55:56 -0500
From:	Rob Clark <robdclark@...il.com>
To:	Saurabh Sengar <saurabh.truth@...il.com>
Cc:	David Airlie <airlied@...ux.ie>, Hai Li <hali@...eaurora.org>,
	Archit Taneja <architt@...eaurora.org>,
	Stephane Viau <sviau@...eaurora.org>,
	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm: msm: dsi: Added missing mutex_unlock

On Sun, Dec 6, 2015 at 2:49 PM, Saurabh Sengar <saurabh.truth@...il.com> wrote:
> in case of failed to get iova, function was returning without releasing
> the mutex. Added it.
>
> Signed-off-by: Saurabh Sengar <saurabh.truth@...il.com>

Reviewed-by: Rob Clark <robdclark@...il.com>

> ---
>  drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
> index 4c49868..13f937b 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
> @@ -849,11 +849,11 @@ static int dsi_tx_buf_alloc(struct msm_dsi_host *msm_host, int size)
>         }
>
>         ret = msm_gem_get_iova_locked(msm_host->tx_gem_obj, 0, &iova);
> +       mutex_unlock(&dev->struct_mutex);
>         if (ret) {
>                 pr_err("%s: failed to get iova, %d\n", __func__, ret);
>                 return ret;
>         }
> -       mutex_unlock(&dev->struct_mutex);
>
>         if (iova & 0x07) {
>                 pr_err("%s: buf NOT 8 bytes aligned\n", __func__);
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/