linux-kernel - Re: [PATCH] mfd: wm831x: fix broken wm831x_unique_id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151208163021.GF6058@localhost.localdomain>
Date:	Tue, 8 Dec 2015 16:30:21 +0000
From:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
To:	Rasmus Villemoes <linux@...musvillemoes.dk>
CC:	Lee Jones <lee.jones@...aro.org>,
	<patches@...nsource.wolfsonmicro.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mfd: wm831x: fix broken wm831x_unique_id_show

On Sun, Dec 06, 2015 at 12:39:39AM +0100, Rasmus Villemoes wrote:
> wm831x_unique_id_show currently displays an interesting pattern of '0'
> and '3' characters which isn't very useful (figuring out why is left
> as an exercise for the reader). Presumably "buf[i]" should have been
> "id[i] & 0xff".
> 
> But while there, it is much simpler to simply use %phN and do all the
> formatting at once.
> 
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
> ---

Acked-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>

Thanks,
Charles
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/