linux-kernel - Re: [PATCH] mfd: wm831x: fix broken wm831x_unique_id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151209085047.GA17876@x1>
Date:	Wed, 9 Dec 2015 08:50:47 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:	patches@...nsource.wolfsonmicro.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: wm831x: fix broken wm831x_unique_id_show

On Sun, 06 Dec 2015, Rasmus Villemoes wrote:

> wm831x_unique_id_show currently displays an interesting pattern of '0'
> and '3' characters which isn't very useful (figuring out why is left
> as an exercise for the reader). Presumably "buf[i]" should have been
> "id[i] & 0xff".
> 
> But while there, it is much simpler to simply use %phN and do all the
> formatting at once.
> 
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
> ---
>  drivers/mfd/wm831x-otp.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/wm831x-otp.c b/drivers/mfd/wm831x-otp.c
> index b90f3e06b6c9..ebac0027f8e0 100644
> --- a/drivers/mfd/wm831x-otp.c
> +++ b/drivers/mfd/wm831x-otp.c
> @@ -47,20 +47,14 @@ static ssize_t wm831x_unique_id_show(struct device *dev,
>  				     struct device_attribute *attr, char *buf)
>  {
>  	struct wm831x *wm831x = dev_get_drvdata(dev);
> -	int i, rval;
> +	int rval;
>  	char id[WM831X_UNIQUE_ID_LEN];
> -	ssize_t ret = 0;
>  
>  	rval = wm831x_unique_id_read(wm831x, id);
>  	if (rval < 0)
>  		return 0;
>  
> -	for (i = 0; i < WM831X_UNIQUE_ID_LEN; i++)
> -		ret += sprintf(&buf[ret], "%02x", buf[i]);
> -
> -	ret += sprintf(&buf[ret], "\n");
> -
> -	return ret;
> +	return sprintf(buf, "%*phN\n", WM831X_UNIQUE_ID_LEN, id);
>  }
>  
>  static DEVICE_ATTR(unique_id, 0444, wm831x_unique_id_show, NULL);

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/