linux-kernel - Re: [PATCH] regmap: speed up the regcache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 8 Dec 2015 17:05:17 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Xiubo Li <lixiubo@...s.chinamobile.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regmap: speed up the regcache_init()

On Thu, Dec 03, 2015 at 10:19:10AM +0800, Xiubo Li wrote:

> If the cache is not used by the device driver, there is not need to
> check the striding of the registers. It will just return 0 from
> regcache_init() and let the register striding be checked in proper
> place when needed.

> -	for (i = 0; i < config->num_reg_defaults; i++)
> -		if (config->reg_defaults[i].reg % map->reg_stride)
> -			return -EINVAL;
> -
>  	if (map->cache_type == REGCACHE_NONE) {
>  		map->cache_bypass = true;
>  		return 0;
>  	}

If we're not using the register cache why are there defaults in the
first place?

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)