lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 10 Dec 2015 10:15:33 +0100
From:	Peter Senna Tschudin <peter.senna@...il.com>
To:	"Geyslan G. Bem" <geyslan@...il.com>
Cc:	Alan Stern <stern@...land.harvard.edu>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/9v2] usb: host: ehci.h: remove space before comma

On Wed, Dec 09, 2015 at 07:32:30PM -0300, Geyslan G. Bem wrote:
> Get rid of spaces before comma.
> 
> Caught by checkpatch: "ERROR: space prohibited before that ','"
> 
> Signed-off-by: Geyslan G. Bem <geyslan@...il.com>
> ---
It is a good idea to include here (after the ---) what changed from V1.
Other than that:
Acked-by: Peter Senna Tschudin <peter.senna@...il.com>

Not related to this patch, I did not receive patch 9/9v2.

>  drivers/usb/host/ehci.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
> index ec61aed..6a36ef4 100644
> --- a/drivers/usb/host/ehci.h
> +++ b/drivers/usb/host/ehci.h
> @@ -852,13 +852,13 @@ static inline u32 hc32_to_cpup (const struct ehci_hcd *ehci, const __hc32 *x)
>  /*-------------------------------------------------------------------------*/
>  
>  #define ehci_dbg(ehci, fmt, args...) \
> -	dev_dbg(ehci_to_hcd(ehci)->self.controller , fmt , ## args)
> +	dev_dbg(ehci_to_hcd(ehci)->self.controller, fmt, ## args)
>  #define ehci_err(ehci, fmt, args...) \
> -	dev_err(ehci_to_hcd(ehci)->self.controller , fmt , ## args)
> +	dev_err(ehci_to_hcd(ehci)->self.controller, fmt, ## args)
>  #define ehci_info(ehci, fmt, args...) \
> -	dev_info(ehci_to_hcd(ehci)->self.controller , fmt , ## args)
> +	dev_info(ehci_to_hcd(ehci)->self.controller, fmt, ## args)
>  #define ehci_warn(ehci, fmt, args...) \
> -	dev_warn(ehci_to_hcd(ehci)->self.controller , fmt , ## args)
> +	dev_warn(ehci_to_hcd(ehci)->self.controller, fmt, ## args)
>  
>  
>  #ifndef CONFIG_DYNAMIC_DEBUG
> -- 
> 2.6.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ