linux-kernel - Re: [PATCH] scsi_dh_alua: fix build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 11 Dec 2015 09:37:27 +0100
From:	Hannes Reinecke <hare@...e.de>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	"James E.J. Bottomley" <JBottomley@...n.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>
Cc:	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org
Subject: Re: [PATCH] scsi_dh_alua: fix build warning

On 12/11/2015 09:36 AM, Sudip Mukherjee wrote:
> We were getting build warning about unused variables "vpd_pg83" and "d"
>
> Fixes: 83ea0e5e3501 ("scsi_dh_alua: use scsi_vpd_tpg_id()")
> Cc: Hannes Reinecke <hare@...e.de>
> Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> ---
> build warning with next-20151211 and build log is at:
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/96209206
> ---
>
>   drivers/scsi/device_handler/scsi_dh_alua.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c
> index f100cbb..5a328bf 100644
> --- a/drivers/scsi/device_handler/scsi_dh_alua.c
> +++ b/drivers/scsi/device_handler/scsi_dh_alua.c
> @@ -320,8 +320,6 @@ static int alua_check_tpgs(struct scsi_device *sdev)
>    */
>   static int alua_check_vpd(struct scsi_device *sdev, struct alua_dh_data *h)
>   {
> -	unsigned char *d;
> -	unsigned char __rcu *vpd_pg83;
>   	int rel_port = -1, group_id;
>
>   	group_id = scsi_vpd_tpg_id(sdev, &rel_port);
>
A fix for this is already queued in Martin Petersens tree.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		               zSeries & Storage
hare@...e.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/