linux-kernel - Re: [PATCH v4 01/58] mtd: nand: denali: add missing nand_release() call in denali

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151211161535.60a96ec2@bbrezillon>
Date:	Fri, 11 Dec 2015 16:15:35 +0100
From:	Boris Brezillon <boris.brezillon@...e-electrons.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Brian Norris <computersforpeace@...il.com>,
	Andrew Lunn <andrew@...n.ch>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	linux-doc@...r.kernel.org, Tony Lindgren <tony@...mide.com>,
	Stefan Agner <stefan@...er.ch>, linux-sunxi@...glegroups.com,
	linux-mtd@...ts.infradead.org,
	Robert Jarzmik <robert.jarzmik@...e.fr>,
	Alexander Clouter <alex@...riz.org.uk>,
	devel@...verdev.osuosl.org,
	Jesper Nilsson <jesper.nilsson@...s.com>,
	linux-samsung-soc@...r.kernel.org,
	Maxim Levitsky <maximlevitsky@...il.com>,
	Jonathan Corbet <corbet@....net>,
	Marek Vasut <marek.vasut@...il.com>,
	Chen-Yu Tsai <wens@...e.org>, Kukjin Kim <kgene@...nel.org>,
	Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>,
	Josh Wu <josh.wu@...el.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	Jason Cooper <jason@...edaemon.net>,
	Wan ZongShun <mcuos.com@...il.com>,
	Steven Miao <realmz6@...il.com>,
	adi-buildroot-devel@...ts.sourceforge.net,
	Haojian Zhuang <haojian.zhuang@...il.com>,
	Mikael Starvik <starvik@...s.com>,
	Krzysztof Halasa <khalasa@...p.pl>,
	Gregory CLEMENT <gregory.clement@...e-electrons.com>,
	linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Ryan Mallon <rmallon@...il.com>, linux-cris-kernel@...s.com,
	David Woodhouse <dwmw2@...radead.org>,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Sascha Hauer <kernel@...gutronix.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Imre Kaloz <kaloz@...nwrt.org>,
	Shawn Guo <shawnguo@...nel.org>,
	Daniel Mack <daniel@...que.org>
Subject: Re: [PATCH v4 01/58] mtd: nand: denali: add missing nand_release()
 call in denali_remove()

Hi Dan,

On Fri, 11 Dec 2015 17:39:47 +0300
Dan Carpenter <dan.carpenter@...cle.com> wrote:

> On Fri, Dec 11, 2015 at 02:53:20PM +0100, Boris Brezillon wrote:
> > Hi Brian,
> > 
> > On Thu, 10 Dec 2015 16:40:08 -0800
> > Brian Norris <computersforpeace@...il.com> wrote:
> > 
> > > On Thu, Dec 10, 2015 at 08:59:45AM +0100, Boris Brezillon wrote:
> > > > Unregister the NAND device from the NAND subsystem when removing a denali
> > > > NAND controller, otherwise the MTD attached to the NAND device is still
> > > > exposed by the MTD layer, and accesses to this device will likely crash
> > > > the system.
> > > > 
> > > > Signed-off-by: Boris Brezillon <boris.brezillon@...e-electrons.com>
> > > > Cc: <stable@...r.kernel.org> #3.8+
> > > 
> > > Does this follow these rules, from
> > > Documentation/stable_kernel_rules.txt?
> > > 
> > >  - It must be obviously correct and tested.
> > > 
> > >  - It must fix a real bug that bothers people (not a, "This could be a
> > >    problem..." type thing).
> > 
> > As you wish, I'll remove those Cc and Fixes tags, or just drop the
> > patch if you think it's useless...
> 
> The fixes tag is a separate thing from CCing stable.  It's useful on by
> itself.  I always put the person who wrote the original patch in the To:
> header so they can review and comment if I have made a mistake.

Noted. I added back the Fixes tag and added Dinh Nguyen (the commit
author) in the loop.

Thanks,

Boris

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/