linux-kernel - Re: [PATCH] backlight: pwm_bl: Fix broken PWM backlight for non-dt platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r3isj3fh.fsf@belgarion.home>
Date:	Fri, 11 Dec 2015 18:33:22 +0100
From:	Robert Jarzmik <robert.jarzmik@...e.fr>
To:	Philipp Zabel <p.zabel@...gutronix.de>
Cc:	Lee Jones <lee.jones@...aro.org>,
	Thierry Reding <thierry.reding@...il.com>,
	linux-pwm@...r.kernel.org, kernel@...gutronix.de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] backlight: pwm_bl: Fix broken PWM backlight for non-dt platforms

Philipp Zabel <p.zabel@...gutronix.de> writes:

> Commit ee65ad0e2a9e ("backlight: pwm_bl: Avoid backlight flicker when
> probed from DT") tries to dereference the device of_node pointer
> unconditionally, causing a NULL pointer dereference on non-dt platforms.
> Fix it by replacing the phandle variable with a node variable and
> by checking that for NULL before dereferencing it.
>
> Reported-by: Robert Jarzmik <robert.jarzmik@...e.fr>
> Signed-off-by: Philipp Zabel <p.zabel@...gutronix.de>
And indeed it does the trick.

Tested-by: Robert Jarzmik <robert.jarzmik@...e.fr>

-- 
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/