linux-kernel - Re: [PATCH] backlight: pwm_bl: Fix broken PWM backlight for non-dt platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151216155614.GI28947@ulmo>
Date:	Wed, 16 Dec 2015 16:56:14 +0100
From:	Thierry Reding <thierry.reding@...il.com>
To:	Philipp Zabel <p.zabel@...gutronix.de>
Cc:	Lee Jones <lee.jones@...aro.org>, linux-pwm@...r.kernel.org,
	Robert Jarzmik <robert.jarzmik@...e.fr>, kernel@...gutronix.de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] backlight: pwm_bl: Fix broken PWM backlight for non-dt
 platforms

On Thu, Dec 10, 2015 at 10:09:06AM +0100, Philipp Zabel wrote:
> Commit ee65ad0e2a9e ("backlight: pwm_bl: Avoid backlight flicker when
> probed from DT") tries to dereference the device of_node pointer
> unconditionally, causing a NULL pointer dereference on non-dt platforms.
> Fix it by replacing the phandle variable with a node variable and
> by checking that for NULL before dereferencing it.
> 
> Reported-by: Robert Jarzmik <robert.jarzmik@...e.fr>
> Signed-off-by: Philipp Zabel <p.zabel@...gutronix.de>
> ---
>  drivers/video/backlight/pwm_bl.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)

Acked-by: Thierry Reding <thierry.reding@...il.com>

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)