linux-kernel - Re: [PATCH 0/7] perf stat: Change event enable code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151216155549.GD6882@krava.brq.redhat.com>
Date:	Wed, 16 Dec 2015 16:55:49 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Adrian Hunter <adrian.hunter@...el.com>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Jiri Olsa <jolsa@...nel.org>,
	lkml <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH 0/7] perf stat: Change event enable code

On Fri, Dec 11, 2015 at 02:42:22PM +0200, Adrian Hunter wrote:

SNIP

> 
> I was wrong about there being any problem using evsel->threads.  While the
> patch "perf evlist: Factor perf_evlist__(enable|disable) function" changes
> the number of threads (from perf_evlist__nr_threads() to thread_map__nr()),
> the system_wide check is still done in perf_evsel__run_ioctl(), so
> everything is fine.
> 
> WRT "[RFC 7/7] perf tools: Remove perf_evlist__(enable|disable)_event
> functions" it might be worth putting the evsel->fd checks that
> perf_evlist__[enable|disable]_event() have into perf_evsel__[enable|disable]().
> But otherwise it looks fine.
> 
> The gap in testing that I was thinking of is below:
> 
> From: Adrian Hunter <adrian.hunter@...el.com>
> Date: Fri, 11 Dec 2015 11:05:11 +0200
> Subject: [PATCH] perf tools: Make perf_evlist__open() open evsels with their
>  cpus and threads (like perf record does)
> 
> 'perf record' uses perf_evsel__open() to open events and passes the evsel->cpus
> and evsel->threads.  Many tests and some tools instead use perf_evlist__open()
> which passes instead evlist->cpus and evlist->threads.
> 
> Make perf_evlist__open() follow the 'perf record' behaviour so that a consistent
> approach is taken.

coo,  I'll queue this one for Arnaldo to pick up together with:
  [RFC 7/7] perf tools: Remove perf_evlist__(enable|disable)_event

thanks,
jirka

> 
> Signed-off-by: Adrian Hunter <adrian.hunter@...el.com>
> ---
>  tools/perf/util/evlist.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
> index d1b6c206bb93..306dacb33d8e 100644
> --- a/tools/perf/util/evlist.c
> +++ b/tools/perf/util/evlist.c
> @@ -1470,7 +1470,7 @@ int perf_evlist__open(struct perf_evlist *evlist)
>  	perf_evlist__update_id_pos(evlist);
>  
>  	evlist__for_each(evlist, evsel) {
> -		err = perf_evsel__open(evsel, evlist->cpus, evlist->threads);
> +		err = perf_evsel__open(evsel, evsel->cpus, evsel->threads);
>  		if (err < 0)
>  			goto out_err;
>  	}
> -- 
> 1.9.1
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/