linux-kernel - Re: [PATCH] nfit: acpi_nfit_notify(): Do not leave device locked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 11 Dec 2015 22:01:48 +0000
From:	"Verma, Vishal L" <vishal.l.verma@...el.com>
To:	Alexey Khoroshilov <khoroshilov@...ras.ru>,
	Ross Zwisler <ross.zwisler@...ux.intel.com>
CC:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Len Brown <lenb@...nel.org>,
	"linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"ldv-project@...uxtesting.org" <ldv-project@...uxtesting.org>
Subject: Re: [PATCH] nfit: acpi_nfit_notify(): Do not leave device locked

On 12/11/15, 13:24, "Alexey Khoroshilov" <khoroshilov@...ras.ru> wrote:

>Even if dev->driver is null because we are being removed,
>it is safer to not leave device locked.
>
>Found by Linux Driver Verification project (linuxtesting.org).
>
>Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru>
>---
> drivers/acpi/nfit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Looks good, thanks!
Reviewed-by: Vishal Verma <vishal.l.verma@...el.com>


>
>diff --git a/drivers/acpi/nfit.c b/drivers/acpi/nfit.c
>index e7ed39bab97d..aa45d4802707 100644
>--- a/drivers/acpi/nfit.c
>+++ b/drivers/acpi/nfit.c
>@@ -1810,7 +1810,7 @@ static void acpi_nfit_notify(struct acpi_device
>*adev, u32 event)
> 	if (!dev->driver) {
> 		/* dev->driver may be null if we're being removed */
> 		dev_dbg(dev, "%s: no driver found for dev\n", __func__);
>-		return;
>+		goto out_unlock;
> 	}
> 
> 	if (!acpi_desc) {
>-- 
>1.9.1
>
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/