lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 14 Dec 2015 10:10:57 +0100 From: Geert Uytterhoeven <geert@...ux-m68k.org> To: Sergey Senozhatsky <sergey.senozhatsky.work@...il.com> Cc: SF Markus Elfring <elfring@...rs.sourceforge.net>, LKML <linux-kernel@...r.kernel.org>, Minchan Kim <minchan@...nel.org>, Nitin Gupta <ngupta@...are.org>, "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>, Julia Lawall <julia.lawall@...6.fr>, Andrew Morton <akpm@...ux-foundation.org>, Jens Axboe <axboe@...com>, "Linux/m68k" <linux-m68k@...r.kernel.org> Subject: Re: [PATCH 2/2] z2ram: Delete a jump label in z2_init() On Mon, Dec 14, 2015 at 1:36 AM, Sergey Senozhatsky <sergey.senozhatsky.work@...il.com> wrote: > Cc Jens, Andrew, Geert > > On (12/11/15 19:26), SF Markus Elfring wrote: >> >> This issue was detected by using the Coccinelle software. >> >> * Let us return directly if a call of the function "register_blkdev" failed. >> >> * Remove the jump label "err" then. >> >> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net> Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org> >> --- >> drivers/block/z2ram.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/block/z2ram.c b/drivers/block/z2ram.c >> index 968f9e5..b07581d 100644 >> --- a/drivers/block/z2ram.c >> +++ b/drivers/block/z2ram.c >> @@ -345,9 +345,8 @@ z2_init(void) >> if (!MACH_IS_AMIGA) >> return -ENODEV; >> >> - ret = -EBUSY; >> if (register_blkdev(Z2RAM_MAJOR, DEVICE_NAME)) >> - goto err; >> + return -EBUSY; >> >> ret = -ENOMEM; >> z2ram_gendisk = alloc_disk(1); >> @@ -374,7 +373,6 @@ out_queue: >> put_disk(z2ram_gendisk); >> out_disk: >> unregister_blkdev(Z2RAM_MAJOR, DEVICE_NAME); >> -err: >> return ret; >> } > > z2ram and zram are different drivers, but the change looks > ok to me. > > z2ram can be improved in many ways, so my question is - do > people still use it? I think it's still used. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists