linux-kernel - Re: [PATCH] lightnvm: add check after mempool allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5670035C.7000004@bjorling.me>
Date:	Tue, 15 Dec 2015 13:11:08 +0100
From:	Matias Bjørling <m@...rling.me>
To:	Javier Gonzalez <javier@...igon.com>
Cc:	linux-kernel@...r.kernel.org, linux-block@...r.kernel.org
Subject: Re: [PATCH] lightnvm: add check after mempool allocation

On 12/15/2015 01:06 PM, Javier Gonzalez wrote:
> Add missing check after mempool allocation.
>
> Signed-off-by: Javier Gonzalez <javier@...xlabs.com>
> ---
>   drivers/lightnvm/rrpc.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/lightnvm/rrpc.c b/drivers/lightnvm/rrpc.c
> index a1e7488..f4bc986 100644
> --- a/drivers/lightnvm/rrpc.c
> +++ b/drivers/lightnvm/rrpc.c
> @@ -287,6 +287,8 @@ static int rrpc_move_valid_pages(struct rrpc *rrpc, struct rrpc_block *rblk)
>   	}
>
>   	page = mempool_alloc(rrpc->page_pool, GFP_NOIO);
> +	if (!page)
> +		return -ENOMEM;
>
>   	while ((slot = find_first_zero_bit(rblk->invalid_pages,
>   					    nr_pgs_per_blk)) < nr_pgs_per_blk) {
>
Thanks Javier, applied for 4.5.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/