[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20151215120703.GA12003@danjae.kornet>
Date: Tue, 15 Dec 2015 21:07:03 +0900
From: Namhyung Kim <namhyung@...nel.org>
To: Jiri Olsa <jolsa@...hat.com>
Cc: Arnaldo Carvalho de Melo <acme@...nel.org>,
Ingo Molnar <mingo@...nel.org>,
Peter Zijlstra <a.p.zijlstra@...llo.nl>,
LKML <linux-kernel@...r.kernel.org>,
David Ahern <dsahern@...il.com>,
Steven Rostedt <rostedt@...dmis.org>,
Frederic Weisbecker <fweisbec@...il.com>,
Andi Kleen <andi@...stfloor.org>,
Wang Nan <wangnan0@...wei.com>
Subject: Re: [PATCH 5/6] perf tools: Add dynamic sort key for tracepoint
events
On Tue, Dec 15, 2015 at 09:53:09AM +0100, Jiri Olsa wrote:
> On Tue, Dec 15, 2015 at 12:46:12AM +0900, Namhyung Kim wrote:
>
> SNIP
>
> >
> > $ perf report -s comm,sched:sched_switch.next_pid,sched:sched_switch.next_comm --stdio
> > ...
> > # Overhead Command next_pid next_comm
> > # ........ ............... .......... ................
> > #
> > 20.86% swapper 17773 transmission-gt
> > 9.64% transmission-gt 0 swapper/0
> > 9.16% transmission-gt 0 swapper/2
> > 5.25% swapper 109 kworker/0:1H
> > 5.21% kworker/0:1H 0 swapper/0
> > 2.14% netctl-auto 0 swapper/2
> > 1.98% netctl-auto 0 swapper/0
> > 1.98% swapper 6524 Xephyr
> > 1.98% swapper 27478 netctl-auto
> > 1.78% transmission-gt 0 swapper/3
> > 1.53% Xephyr 0 swapper/0
> > 1.29% netctl-auto 0 swapper/1
> > 1.29% swapper 27476 netctl-auto
> > 1.21% netctl-auto 0 swapper/3
> > 1.17% swapper 233 irq/33-iwlwifi
> >
> > Note that pid 0 exists for each cpu so have comm of 'swapper/N'.
>
> could we also add by default all tracepoint fields in case none
> is specified and the event to display is tracepoint?
Seems like a good suggestion. We can check if there's only one
tracepoint event, then use dynamic sort keys for all fields. But I
think we should skip common fields in that case.
>
> also an extra field that would hold/show the 'print fmt' display ?
Do you want a single extra field per event or per field?
Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists