linux-kernel - Re: [PATCH] net: emac: emac gigabit ethernet controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56702EEC.8000506@codeaurora.org>
Date:	Tue, 15 Dec 2015 09:17:00 -0600
From:	Timur Tabi <timur@...eaurora.org>
To:	Arnd Bergmann <arnd@...db.de>,
	Christopher Covington <cov@...eaurora.org>
Cc:	Florian Fainelli <f.fainelli@...il.com>,
	Gilad Avidov <gavidov@...eaurora.org>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, sdharia@...eaurora.org,
	shankerd@...eaurora.org, gregkh@...uxfoundation.org,
	vikrams@...eaurora.org
Subject: Re: [PATCH] net: emac: emac gigabit ethernet controller driver

Arnd Bergmann wrote:
> We generally want to use readl/writel rather than the relaxed versions,
> unless it is in performance-critical code.

What about if we have 20+ writes in a row, for example, when 
initializing a part?  I've seen code like this:

	writel_relaxed(...);
	writel_relaxed(...);
	writel_relaxed(...);
	...
	writel(...); // HW now inited, so enable

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/