linux-kernel - Re: [PATCH 03/10] perf, tools, stat: Avoid fractional digits for integer scales

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABPqkBRdcKzyY-W+VWuqAtpKc=ejmvkC=EAq41grXyPfs4cgmg@mail.gmail.com>
Date:	Wed, 16 Dec 2015 06:22:46 -0800
From:	Stephane Eranian <eranian@...gle.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Jiri Olsa <jolsa@...nel.org>, Ingo Molnar <mingo@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 03/10] perf, tools, stat: Avoid fractional digits for
 integer scales

On Tue, Dec 15, 2015 at 4:54 PM, Andi Kleen <andi@...stfloor.org> wrote:
> From: Andi Kleen <ak@...ux.intel.com>
>
> When the scaling factor is a full integer don't display fractional
> digits. This avoids unnecessary .00 output for topdown metrics
> with scale factors.
>
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>
> ---
>  tools/perf/builtin-stat.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index 0c7cdda..1faa6fc 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -63,6 +63,7 @@
>  #include <stdlib.h>
>  #include <sys/prctl.h>
>  #include <locale.h>
> +#include <math.h>
>
>  #define DEFAULT_SEPARATOR      " "
>  #define CNTR_NOT_SUPPORTED     "<not supported>"
> @@ -739,12 +740,12 @@ static void abs_printout(int id, int nr, struct perf_evsel *evsel, double avg)
>         const char *fmt;
>
>         if (csv_output) {
> -               fmt = sc != 1.0 ?  "%.2f%s" : "%.0f%s";
> +               fmt = sc != 1.0 && floor(sc) != sc ?  "%.2f%s" : "%.0f%s";
>         } else {
>                 if (big_num)
> -                       fmt = sc != 1.0 ? "%'18.2f%s" : "%'18.0f%s";
> +                       fmt = sc != 1.0 && floor(sc) != sc ? "%'18.2f%s" : "%'18.0f%s";

if sc is 1.0 then floor(sc) == sc and you'd get the else branch as well, so you
probably do not need the sc != 1.0 test anymore.

>                 else
> -                       fmt = sc != 1.0 ? "%18.2f%s" : "%18.0f%s";
> +                       fmt = sc != 1.0 && floor(sc) != sc ? "%18.2f%s" : "%18.0f%s";
>         }
>
>         aggr_printout(evsel, id, nr);
> --
> 2.4.3
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/