linux-kernel - Re: [PATCH 11/11] tty: serial: 8250: Delete commented code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <567199D6.4050106@hurleysoftware.com>
Date:	Wed, 16 Dec 2015 09:05:26 -0800
From:	Peter Hurley <peter@...leysoftware.com>
To:	Anton Wuerfel <anton.wuerfel@....de>, linux-serial@...r.kernel.org
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.com>,
	"James E.J. Bottomley" <jejb@...isc-linux.org>,
	Helge Deller <deller@....de>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Qipeng Zha <qipeng.zha@...el.com>,
	Desmond Liu <desmondl@...adcom.com>,
	Wang Long <long.wanglong@...wei.com>,
	Matt Redfearn <matt.redfearn@...tec.com>,
	Paul Burton <paul.burton@...tec.com>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Peter Hung <hpeter@...il.com>,
	Soeren Grunewald <soeren.grunewald@...y.de>,
	Adam Lee <adam.lee@...onical.com>,
	"Maciej S. Szmigiero" <mail@...iej.szmigiero.name>,
	Mans Rullgard <mans@...sr.com>, linux-kernel@...r.kernel.org,
	linux-parisc@...r.kernel.org, linux-kernel@...cs.fau.de,
	Phillip Raffeck <phillip.raffeck@....de>
Subject: Re: [PATCH 11/11] tty: serial: 8250: Delete commented code

Hi Anton,

On 12/16/2015 07:36 AM, Anton Wuerfel wrote:
> This patch removes code which has been commented out. It serves no
> documentary purposes and decreases the readability of the remaining code.
> Furthermore the comment style causes checkpatch warnings. If this code
> should ever be needed again, git keeps track of it.

This is bad idea.

I can count on one hand the number of times I've tried to find deleted
code in git. How would you go about finding all deleted sub-vendor
ids in the 16.5M-line Linux source tree, say since 2.6.32?

Regards,
Peter Hurley

> Signed-off-by: Anton Würfel <anton.wuerfel@....de>
> Signed-off-by: Phillip Raffeck <phillip.raffeck@....de>
> CC: linux-kernel@...cs.fau.de
> ---
>  drivers/tty/serial/8250/8250_pci.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
> index 3bc0303..9136f0f 100644
> --- a/drivers/tty/serial/8250/8250_pci.c
> +++ b/drivers/tty/serial/8250/8250_pci.c
> @@ -4928,16 +4928,9 @@ static struct pci_device_id serial_pci_tbl[] = {
>  	{	PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF0,
>  		0x1208, 0x0004, 0, 0,
>  		pbn_b0_4_921600 },
> -/*	{	PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF0,
> -		0x1402, 0x0002, 0, 0,
> -		pbn_b0_2_921600 }, */
> -/*	{	PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF0,
> -		0x1404, 0x0004, 0, 0,
> -		pbn_b0_4_921600 }, */
>  	{	PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF1,
>  		0x1208, 0x0004, 0, 0,
>  		pbn_b0_4_921600 },
> -
>  	{	PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF2,
>  		0x1204, 0x0004, 0, 0,
>  		pbn_b0_4_921600 },
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/