linux-kernel - Re: [PATCH v3 2/4] crypto: niagara: Use precalculated hash from headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151217084824.GA20217@Red>
Date:	Thu, 17 Dec 2015 09:48:24 +0100
From:	LABBE Corentin <clabbe.montjoie@...il.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	davem@...emloft.net, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/4] crypto: niagara: Use precalculated hash from
 headers

On Thu, Dec 17, 2015 at 04:40:18PM +0800, Herbert Xu wrote:
> On Tue, Dec 15, 2015 at 02:00:21PM +0100, LABBE Corentin wrote:
> > Precalculated hash for empty message are now present in hash headers.
> > This patch just use them.
> > 
> > Signed-off-by: LABBE Corentin <clabbe.montjoie@...il.com>
> > ---
> >  drivers/crypto/Kconfig   |  2 ++
> >  drivers/crypto/n2_core.c | 33 ++++++---------------------------
> >  2 files changed, 8 insertions(+), 27 deletions(-)
> > 
> > diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
> > index b9ec295..dea754b 100644
> > --- a/drivers/crypto/Kconfig
> > +++ b/drivers/crypto/Kconfig
> > @@ -194,6 +194,8 @@ config CRYPTO_DEV_NIAGARA2
> >         select CRYPTO_DES
> >         select CRYPTO_BLKCIPHER
> >         select CRYPTO_HASH
> > +       select CRYPTO_MD5
> > +       select CRYPTO_SHA1
> 
> Don't we need CRYPTO_SHA256 as well?
> 
> Thanks,

Hello

You are right, I missed it also in ccp/ux500.

Regards

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/