linux-kernel - Re: [PATCH v6 0/6] Add mipi dsi support for rk3288

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3523259.ZRgH1Shd9Y@diego>
Date:	Thu, 17 Dec 2015 10:29:53 +0100
From:	Heiko Stübner <heiko@...ech.de>
To:	Chris Zhong <zyw@...k-chips.com>
Cc:	linux-rockchip@...ts.infradead.org, mark.yao@...k-chips.com,
	treding@...dia.com, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
	Kumar Gala <galak@...eaurora.org>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Rob Herring <robh+dt@...nel.org>,
	David Airlie <airlied@...ux.ie>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Russell King <linux@....linux.org.uk>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v6 0/6] Add mipi dsi support for rk3288

Hi Chris,

Am Mittwoch, 16. Dezember 2015, 18:10:10 schrieb Chris Zhong:
> The rk3288 MIPI DSI is a Synopsys DesignWare MIPI DSI host controller
> IP. This series adds support for a Synopsys DesignWare MIPI DSI host
> controller DRM driver.
> 
> The MIPI DSI feature is tested on rk3288 evb board, backport them to
> chrome os kernel chrome_v3.14, and it can display normally.
> 
> This patchset is base on the patchset from Ying.liu@...escale.com.
> <http://www.spinics.net/lists/dri-devel/msg77181.html>
> 
> According to the suggestion from Thierry, I have get rid of the bridge,
> and register the encoder & connecter in drm/rockchip/dw-mipi-dsi.c.

from my point it looks good (although I cannot really speak on the drm-related 
internals).

But I do think we'll be doing atomic modesetting conversion first (last 
version posted from Mark today), so you should probably make sure your dsi 
driver still works after that conversion and make changes if needed.


Heiko

> 
> 
> Changes in v6:
> - update the document, since the bridge device has been deleted.
> - Do not use bridge driver (Thierry Reding)
> - Optimization the phy init sequence
> 
> Changes in v5:
> - modify the clk name to SCLK_MIPIDSI_24M
> - add a blank line befor lcd_en
> 
> Changes in v4:
> - use clk_round_rate to check the clock rate in vop_crtc_mode_fixup
> 
> Changes in v3:
> - move dw_mipi_dsi_rockchip.txt to bindings/display/rockchip/
> 
> Chris Zhong (5):
>   drm/rockchip: return a true clock rate to adjusted_mode
>   Documentation: dt-bindings: Add bindings for rk3288 DW MIPI DSI driver
>   drm: rockchip: Support Synopsys DW MIPI DSI
>   ARM: dts: rockchip: add rk3288 mipi_dsi nodes
>   ARM: dts: rockchip: add support mipi panel tv080wum-nl0
> 
> Liu Ying (1):
>   drm/dsi: Add a helper to get bits per pixel of MIPI DSI pixel format
> 
>  .../display/rockchip/dw_mipi_dsi_rockchip.txt      |   60 +
>  arch/arm/boot/dts/rk3288-evb.dtsi                  |   20 +-
>  arch/arm/boot/dts/rk3288.dtsi                      |   39 +
>  drivers/gpu/drm/rockchip/Kconfig                   |   10 +
>  drivers/gpu/drm/rockchip/Makefile                  |    1 +
>  drivers/gpu/drm/rockchip/dw-mipi-dsi.c             | 1200
> ++++++++++++++++++++ drivers/gpu/drm/rockchip/rockchip_drm_vop.c        |  
>  8 +
>  include/drm/drm_mipi_dsi.h                         |   14 +
>  8 files changed, 1351 insertions(+), 1 deletion(-)
>  create mode 100644
> Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt
> create mode 100644 drivers/gpu/drm/rockchip/dw-mipi-dsi.c

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/