linux-kernel - [PATCH] ASoC: sgtl5000: fix VAG power up timing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1450346843-6700-1-git-send-email-jean-michel.hautbois@veo-labs.com>
Date:	Thu, 17 Dec 2015 11:07:23 +0100
From:	Jean-Michel Hautbois <jhautbois@...il.com>
To:	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Cc:	fbrozovic@...il.com, alexander.stein@...tec-electronic.com,
	eric.nelson@...ndarydevices.com, gianlucarenzi@...ekelettronica.it,
	lars@...afoo.de, tiwai@...e.com, perex@...ex.cz,
	broonie@...nel.org, lgirdwood@...il.com,
	Jean-Michel Hautbois <jean-michel.hautbois@...-labs.com>
Subject: [PATCH] ASoC: sgtl5000: fix VAG power up timing

When power up, a "pop" is heard on line-in and mic-in.
An analysis of the PCM shows it lasts ~400ms
and looks like a filter response.
VAG power up should be delayed by 400ms as VAG power down is.

Signed-off-by: Jean-Michel Hautbois <jean-michel.hautbois@...-labs.com>
---
 sound/soc/codecs/sgtl5000.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c
index f540f82..08b4046 100644
--- a/sound/soc/codecs/sgtl5000.c
+++ b/sound/soc/codecs/sgtl5000.c
@@ -189,6 +189,7 @@ static int power_vag_event(struct snd_soc_dapm_widget *w,
 	case SND_SOC_DAPM_POST_PMU:
 		snd_soc_update_bits(codec, SGTL5000_CHIP_ANA_POWER,
 			SGTL5000_VAG_POWERUP, SGTL5000_VAG_POWERUP);
+		msleep(400);
 		break;
 
 	case SND_SOC_DAPM_PRE_PMD:
-- 
2.6.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/