linux-kernel - Re: [PATCH v2 10/11] tty: serial: 8250: Replace printk by pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1450442546.30729.217.camel@intel.com>
Date:	Fri, 18 Dec 2015 12:42:08 +0000
From:	"Shevchenko, Andriy" <andriy.shevchenko@...el.com>
To:	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	"anton.wuerfel@....de" <anton.wuerfel@....de>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"mail@...iej.szmigiero.name" <mail@...iej.szmigiero.name>,
	"desmondl@...adcom.com" <desmondl@...adcom.com>,
	"Zha, Qipeng" <qipeng.zha@...el.com>,
	"heikki.krogerus@...ux.intel.com" <heikki.krogerus@...ux.intel.com>,
	"long.wanglong@...wei.com" <long.wanglong@...wei.com>,
	"soeren.grunewald@...y.de" <soeren.grunewald@...y.de>,
	"deller@....de" <deller@....de>,
	"jslaby@...e.com" <jslaby@...e.com>,
	"phillip.raffeck@....de" <phillip.raffeck@....de>,
	"paul.burton@...tec.com" <paul.burton@...tec.com>,
	"hpeter@...il.com" <hpeter@...il.com>,
	"ralf@...ux-mips.org" <ralf@...ux-mips.org>,
	"linux-kernel@...cs.fau.de" <linux-kernel@...cs.fau.de>,
	"mans@...sr.com" <mans@...sr.com>,
	"adam.lee@...onical.com" <adam.lee@...onical.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"jejb@...isc-linux.org" <jejb@...isc-linux.org>,
	"linux-parisc@...r.kernel.org" <linux-parisc@...r.kernel.org>,
	"peter@...leysoftware.com" <peter@...leysoftware.com>,
	"matt.redfearn@...tec.com" <matt.redfearn@...tec.com>,
	"k.kozlowski@...sung.com" <k.kozlowski@...sung.com>
Subject: Re: [PATCH v2 10/11] tty: serial: 8250: Replace printk by pr_*

On Fri, 2015-12-18 at 14:32 +0200, Andy Shevchenko wrote:
> On Fri, 2015-12-18 at 12:22 +0100, Anton Wuerfel wrote:
> 
> 
> >  This comes with a slight change in behaviour as
> > pr_debug is configurable via CONFIG_DYNAMIC_DEBUG, whereas
> > printk(KERN_DEBUG ...) is not.
> 
> --- a/drivers/tty/serial/8250/8250_pnp.c
> > +++ b/drivers/tty/serial/8250/8250_pnp.c
> > @@ -465,9 +465,9 @@ serial_pnp_probe(struct pnp_dev *dev, const
> > struct pnp_device_id *dev_id)

One more thing just noticed that is ->probe() function where you have
struct device defined, it might be worth to change to dev_* macros
instead of pr_ at the same time for some functions.

So, here it would be dev_dbg(&dev->dev, …) I suppose.


-- 
Andy Shevchenko <andriy.shevchenko@...el.com>
Intel Finland Oy
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.