linux-kernel - Re: [PATCH v2 10/11] tty: serial: 8250: Replace printk by pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <567421FC.7080005@hurleysoftware.com>
Date:	Fri, 18 Dec 2015 07:10:52 -0800
From:	Peter Hurley <peter@...leysoftware.com>
To:	Anton Wuerfel <anton.wuerfel@....de>
Cc:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	linux-serial@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.com>,
	"James E.J. Bottomley" <jejb@...isc-linux.org>,
	Helge Deller <deller@....de>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Qipeng Zha <qipeng.zha@...el.com>,
	Desmond Liu <desmondl@...adcom.com>,
	Wang Long <long.wanglong@...wei.com>,
	Matt Redfearn <matt.redfearn@...tec.com>,
	Paul Burton <paul.burton@...tec.com>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Peter Hung <hpeter@...il.com>,
	Soeren Grunewald <soeren.grunewald@...y.de>,
	Adam Lee <adam.lee@...onical.com>,
	"Maciej S. Szmigiero" <mail@...iej.szmigiero.name>,
	Mans Rullgard <mans@...sr.com>, linux-kernel@...r.kernel.org,
	linux-parisc@...r.kernel.org, linux-kernel@...cs.fau.de,
	Phillip Raffeck <phillip.raffeck@....de>
Subject: Re: [PATCH v2 10/11] tty: serial: 8250: Replace printk by pr_*

Hi Anton,

On 12/18/2015 04:32 AM, Andy Shevchenko wrote:
> On Fri, 2015-12-18 at 12:22 +0100, Anton Wuerfel wrote:
> 
> 
>>  This comes with a slight change in behaviour as
>> pr_debug is configurable via CONFIG_DYNAMIC_DEBUG, whereas
>> printk(KERN_DEBUG ...) is not.

Please make this one change and the changes Andy is suggesting
it a separate patch.

That way the commit can describe how the get the equivalent
behavior (ie., with CONFIG_DYNAMIC_DEBUG) rather than with
-DSERIAL_DEBUG_PNP.

Regards,
Peter Hurley

> --- a/drivers/tty/serial/8250/8250_pnp.c
>> +++ b/drivers/tty/serial/8250/8250_pnp.c
>> @@ -465,9 +465,9 @@ serial_pnp_probe(struct pnp_dev *dev, const
>> struct pnp_device_id *dev_id)
>>  		return -ENODEV;
>>  
>>  #ifdef SERIAL_DEBUG_PNP
>> -	printk(KERN_DEBUG
> 
> I think it's not okay.
> 
> The rationale to have printk(KERN_DEBUG …) here is to allow a
> compilation with support of those messages independently on
> DYNAMIC_DEBUG.
> 
> If you want to switch to DYNAMIC_DEBUG you have to carefully check what
> is done under SERIAL_DEBUG_PNP.
> 
> git grep on current linux-next shows that SERIAL_DEBUG_PNP is an
> orphan.
> 
> So, I would suggest to remove #ifdef.
> 
>> -		"Setup PNP port: port %x, mem 0x%lx, irq %d, type
>> %d\n",
>> -		       uart.port.iobase, uart.port.mapbase,
>> uart.port.irq, uart.port.iotype);
>> +	pr_debug("Setup PNP port: port %x, mem 0x%lx, irq %d, type
>> %d\n",
>> +		 uart.port.iobase, uart.port.mapbase,
>> +		 uart.port.irq, uart.port.iotype);
>>  #endif
>>
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/