linux-kernel - Re: blackfin-cpufreq: How to mark cpu_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5677CB72.8090504@users.sourceforge.net>
Date:	Mon, 21 Dec 2015 10:50:42 +0100
From:	SF Markus Elfring <elfring@...rs.sourceforge.net>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, linux-pm@...r.kernel.org,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	kernel-janitors@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: blackfin-cpufreq: How to mark cpu_set_cclk() as static?

> Since you reported the issue, it will be good if you can send a patch
> for this as well.

I'm sorry if I become a bit picky for this implementation detail.

In which order would you prefer that the properties of the
function "cpu_set_cclk" will be improved?
* Should the linkage specifier be added on a separate source code line?
* Can this fix be combined with my previous update suggestion for
  the return type?

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/