linux-kernel - Re: [PATCH 1/6] perf, tools, stat: Abstract stat metrics printing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151221154232.GA13912@krava.brq.redhat.com>
Date:	Mon, 21 Dec 2015 16:42:32 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	acme@...nel.org, jolsa@...nel.org, mingo@...nel.org,
	linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 1/6] perf, tools, stat: Abstract stat metrics printing

On Mon, Dec 14, 2015 at 06:04:14PM -0800, Andi Kleen wrote:

SNIP

> -				   double avg, int cpu, enum aggr_mode aggr)
> +void perf_stat__print_shadow_stats(struct perf_evsel *evsel,
> +				   double avg, int cpu,
> +				   struct perf_stat_output_ctx *out)
>  {
> +	void *ctxp = out->ctx;
> +	print_metric_t print_metric = out->print_metric;
>  	double total, ratio = 0.0, total2;
>  	int ctx = evsel_context(evsel);
>  
> @@ -307,119 +302,145 @@ void perf_stat__print_shadow_stats(FILE *out, struct perf_evsel *evsel,
>  		total = avg_stats(&runtime_cycles_stats[ctx][cpu]);
>  		if (total) {
>  			ratio = avg / total;
> -			fprintf(out, " #   %5.2f  insns per cycle        ", ratio);
> +			print_metric(ctxp, NULL, "%7.2f ",
> +					"insn per cycle", ratio);
>  		} else {
> -			fprintf(out, "                                   ");
> +			print_metric(ctxp, NULL, NULL, "insn per cycle", 0);
>  		}
>  		total = avg_stats(&runtime_stalled_cycles_front_stats[ctx][cpu]);
>  		total = max(total, avg_stats(&runtime_stalled_cycles_back_stats[ctx][cpu]));
>  
> +		out->new_line(ctxp);
>  		if (total && avg) {
>  			ratio = total / avg;
> -			fprintf(out, "\n");

you haven't address my first comment in here http://marc.info/?l=linux-kernel&m=144662610723134&w=2

also please rebase to latest acme/perf/core
FYI there's been some stat changes, but your branch cleanly rebased for me

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/