linux-kernel - Re: [PATCH 1/6] perf, tools, stat: Abstract stat metrics printing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151222011630.GE15533@two.firstfloor.org>
Date:	Tue, 22 Dec 2015 02:16:30 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Andi Kleen <andi@...stfloor.org>, acme@...nel.org,
	jolsa@...nel.org, mingo@...nel.org, linux-kernel@...r.kernel.org,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 1/6] perf, tools, stat: Abstract stat metrics printing

> > -			fprintf(out, "                                   ");
> > +			print_metric(ctxp, NULL, NULL, "insn per cycle", 0);
> >  		}
> >  		total = avg_stats(&runtime_stalled_cycles_front_stats[ctx][cpu]);
> >  		total = max(total, avg_stats(&runtime_stalled_cycles_back_stats[ctx][cpu]));
> >  
> > +		out->new_line(ctxp);
> >  		if (total && avg) {
> >  			ratio = total / avg;
> > -			fprintf(out, "\n");
> 
> you haven't address my first comment in here http://marc.info/?l=linux-kernel&m=144662610723134&w=2

The new_line is always needed because stalled cycles is always printed.

The reason it is always printed is that metric-only needs to see all the
metrics for its column headers. That's why there are else cases
everywhere.


-Andi
-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/