linux-kernel - Re: [PATCH 1/2] usb: gadget: f

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87egeepe5p.fsf@saruman.tx.rr.com>
Date:	Tue, 22 Dec 2015 11:49:06 -0600
From:	Felipe Balbi <balbi@...com>
To:	"Felipe F. Tonello" <eu@...ipetonello.com>,
	<linux-usb@...r.kernel.org>
CC:	<linux-kernel@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Robert Baldyga <r.baldyga@...sung.com>,
	Clemens Ladisch <clemens@...isch.de>
Subject: Re: [PATCH 1/2] usb: gadget: f_midi: refactor state machine


Hi,

"Felipe F. Tonello" <eu@...ipetonello.com> writes:
> This refactor includes the following:
>  * Cleaner state machine code;
>  * Reset state if MIDI message parsed is non-conformant;
>  * Fixed bug when a conformant MIDI message was followed by a non-conformant
>    causing the MIDI-USB message to use old temporary data (port->data[0..1]),
>    thus packing a wrong MIDI-USB request.

we don't do more than one logical thing per patch. Please split this up.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)