linux-kernel - Re: [PATCH v3 68/77] ncr5380: Fix whitespace issues using regexp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1450833749.2381.27.camel@HansenPartnership.com>
Date:	Tue, 22 Dec 2015 17:22:29 -0800
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Finn Thain <fthain@...egraphics.com.au>,
	Joe Perches <joe@...ches.com>
Cc:	Michael Schmitz <schmitzmic@...il.com>, linux-m68k@...r.kernel.org,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	"Martin K. Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH v3 68/77] ncr5380: Fix whitespace issues using regexp

On Wed, 2015-12-23 at 11:56 +1100, Finn Thain wrote:
> On Tue, 22 Dec 2015, Joe Perches wrote:
> 
> > On Tue, 2015-12-22 at 12:18 +1100, Finn Thain wrote:
> > > This patch is just the result of two substitutions. The first
> removes 
> > > any tabs and spaces at the end of the line. The second replaces
> runs 
> > > of tabs and spaces at the beginning of comment lines with a
> single 
> > > space.
> > 
> > I think the second of these isn't done well.
> 
> The aim of this patch is not to fix code style, but to make it 
> possible to compare these two files so that the fork can be repaired. 
> Regexp is very helpful in creating uniformity (and a minimal diff).
> 
> If this was a coding style issue, we would be discussing the use of 
> kernel-doc format for the affected comments, not whitespace.
> 
> > Many of these comments post reformatting are
> > much worse to read because of lost alignment.
> 
> You exaggerate a very trivial point.
> 
> I admit that a small proportion of comments are slightly less 
> readable. But it is the diff that needs to be readable in order to 
> resolve the fork.
> 
> As I said in patch 0, I am aware that this patch series can be 
> faulted on trivial grounds but in order to avoid churn I don't wish 
> to address those issues until the fork has been resolved.

I don't think it is trivial.  I can't actually find a single instance
in this patch where collapsing the space at the start of the comment
looks justified; most of the time it eliminates intended formatting.
Even if there's an odd one I've missed where space at the beginning of
a comment is a problem, I think not doing that part of the regexp and
just correcting the odd missed case by hand later will be much better.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/