linux-kernel - Re: [PATCH v3 68/77] ncr5380: Fix whitespace issues using regexp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1512231255350.30030@nippy.intranet>
Date:	Wed, 23 Dec 2015 13:03:02 +1100 (AEDT)
From:	Finn Thain <fthain@...egraphics.com.au>
To:	Joe Perches <joe@...ches.com>
cc:	"James E.J. Bottomley" <JBottomley@...n.com>,
	Michael Schmitz <schmitzmic@...il.com>,
	linux-m68k@...r.kernel.org, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"Martin K. Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH v3 68/77] ncr5380: Fix whitespace issues using regexp


On Tue, 22 Dec 2015, Joe Perches wrote:

> On Wed, 2015-12-23 at 11:56 +1100, Finn Thain wrote:
> > On Tue, 22 Dec 2015, Joe Perches wrote:
> > 
> > > On Tue, 2015-12-22 at 12:18 +1100, Finn Thain wrote:
> > > > This patch is just the result of two substitutions. The first 
> > > > removes any tabs and spaces at the end of the line. The second 
> > > > replaces runs of tabs and spaces at the beginning of comment lines 
> > > > with a single space.
> > > 
> > > I think the second of these isn't done well.
> > 
> > The aim of this patch is not to fix code style, but to make it 
> > possible to compare these two files so that the fork can be repaired. 
> > Regexp is very helpful in creating uniformity (and a minimal diff).
> > 
> > If this was a coding style issue, we would be discussing the use of 
> > kernel-doc format for the affected comments, not whitespace.
> > 
> > > Many of these comments post reformatting are much worse to read 
> > > because of lost alignment.
> > 
> > You exaggerate a very trivial point.
> 
> <shrug>
> 
> I prefer that all patches be improvements.
> 

Agreed. But the example you cited is an improvement, in that it creates 
consistency.

Like you, I prefer to see formal parameters aligned when wrapped. But this 
isn't a formal parameter list, it is a comment, and no comment should 
duplicate code.

Can you suggest a better regexp? Since this is patch 68 in the series, 
there is a good chance that it will need to be regenerated.

> > I admit that a small proportion of comments are slightly less 
> > readable. But it is the diff that needs to be readable in order to 
> > resolve the fork.
> 
> diff -w works well.
> 

Yes, it works well at times. For this I prefer to use meld. It does have 
text filters that allow the user to elide differences that match a given 
regexp. But I don't want every meld user to have to write those regexps.

--