linux-kernel - Re: [PATCH] gpiolib: Fix uninitialized variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbgepNZtjyE1Y_5KXjR+d7hakTSecqk0VWX+kMeFhOcAQ@mail.gmail.com>
Date:	Thu, 24 Dec 2015 10:07:55 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Ross Zwisler <ross.zwisler@...ux.intel.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Bamvor Jian Zhang <bamvor.zhangjian@...aro.org>,
	Alexandre Courbot <gnurou@...il.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH] gpiolib: Fix uninitialized variable warning

On Wed, Dec 23, 2015 at 10:46 PM, Ross Zwisler
<ross.zwisler@...ux.intel.com> wrote:

> Commit ef7c7553039b ("gpiolib: improve overlap check of range of gpio")
> introduced the following compiler warning:
>
> drivers/gpio/gpiolib.c: In function ‘gpiochip_add’:
> drivers/gpio/gpiolib.c:193:20: warning: ‘iterator’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>   struct gpio_chip *iterator;
>                     ^
>
> Fix this by initializing 'iterator' to NULL.
>
> Signed-off-by: Ross Zwisler <ross.zwisler@...ux.intel.com>
> ---
>
> This was found in next-20151223.

Several people reported this and I was waiting for a proper
fix from Bamvor (as it is a false compile warning and doesn't
really indicate a real error) but now I'll apply this to
get rid of all the reports and patches filling my mailbox...

Merry Christmas!

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/